Disable MBT tests if the "mocks" feature is not enabled #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adizere
requested changes
Feb 12, 2021
Codecov Report
@@ Coverage Diff @@
## master #643 +/- ##
=========================================
+ Coverage 13.6% 46.4% +32.7%
=========================================
Files 69 152 +83
Lines 3752 10165 +6413
Branches 1374 0 -1374
=========================================
+ Hits 513 4722 +4209
- Misses 2618 5443 +2825
+ Partials 621 0 -621
Continue to review full report at Codecov.
|
Done in 361e046. There were two entries for BUG FIXES; I also fixed that. |
adizere
approved these changes
Feb 12, 2021
hu55a1n1
pushed a commit
to hu55a1n1/hermes
that referenced
this pull request
Sep 13, 2022
…ems#643) * Add structure to MBT * Only run model_based test if mocks feature is enabled * Remove model_based test from the executor * update CHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #642
Description
Before, running
cargo testin the root folder would run the MBT tests successfully. However, runningcargo testinside themodules/folder doesn't work because the"mocks"is missing. This hints that runningcargo testin the root folder is equivalent to runningcargo test --all-features, but I couldn't find the corresponding documentation.Ideally we would like to always enable the
"mocks"feature when running tests, independently from where, but unfortunately this seems to not be supported: rust-lang/cargo#2911This PR disables the MBT tests if the "mocks" feature is not enabled, which seemed to be the best workaround suggested in the previous issue: rust-lang/cargo#2911 (comment)
Now, running
cargo testin the root folder still runs the MBT tests successfully, while runningcargo testinside themodules/folder simply ignores them. To also run the MBT tests inside themodules/folder one has to:cargo test --features mocksThis PR also adds more structure to the MBT tests, as suggested by @adizere in #601 (comment). This is a good suggestion since each file in the
tests/folder is compiled as it own crate. As a result,step.rs,modelator.rsandmodel_based.rswere all compiled individually, even though only the latter had a test in it.model_based.rswas renamed tombt.rsjust to minimize the diff in this PR.For contributor use:
docs/) and code comments.Files changedin the Github PR explorer.